Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internalize IDB dependency #8518

Closed
wants to merge 5 commits into from
Closed

Internalize IDB dependency #8518

wants to merge 5 commits into from

Conversation

dlarocque
Copy link
Contributor

Internalize the IDB dependency, since it uses ES2018 syntax, while our bundles use <= ES2017.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 72825f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 24, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (beaa4df)Merge (3809f73)Diff
    browser18.4 kB23.7 kB+5.27 kB (+28.6%)
    module18.4 kB23.7 kB+5.27 kB (+28.6%)

  • @firebase/installations

    TypeBase (beaa4df)Merge (3809f73)Diff
    browser17.8 kB23.0 kB+5.27 kB (+29.7%)
    module17.8 kB23.0 kB+5.27 kB (+29.7%)

  • @firebase/messaging

    TypeBase (beaa4df)Merge (3809f73)Diff
    browser21.3 kB26.8 kB+5.48 kB (+25.7%)
    module21.3 kB26.8 kB+5.48 kB (+25.7%)

  • @firebase/messaging-sw

    TypeBase (beaa4df)Merge (3809f73)Diff
    module23.6 kB29.1 kB+5.48 kB (+23.2%)

  • bundle

    37 size changes

    TypeBase (beaa4df)Merge (3809f73)Diff
    analytics (logEvent)44.6 kB47.9 kB+3.29 kB (+7.4%)
    app-check (CustomProvider)37.5 kB37.5 kB+1 B (+0.0%)
    app-check (ReCaptchaEnterpriseProvider)40.0 kB40.0 kB-1 B (-0.0%)
    app-check (ReCaptchaV3Provider)40.0 kB40.0 kB-1 B (-0.0%)
    auth (Anonymous)76.3 kB76.3 kB-6 B (-0.0%)
    auth (EmailAndPassword)84.6 kB84.5 kB-9 B (-0.0%)
    auth (GoogleFBTwitterGitHubPopup)103 kB103 kB-1 B (-0.0%)
    auth (GooglePopup)100 kB100 kB-9 B (-0.0%)
    auth (GoogleRedirect)100 kB100 kB-9 B (-0.0%)
    auth (Phone)86.9 kB86.9 kB-6 B (-0.0%)
    firestore (CSI Auto Indexing Disable and Delete)270 kB270 kB+1 B (+0.0%)
    firestore (CSI Auto Indexing Enable)270 kB270 kB+1 B (+0.0%)
    firestore (Persistence)303 kB303 kB+1 B (+0.0%)
    firestore (Query Cursors)242 kB242 kB-1 B (-0.0%)
    firestore (Query)240 kB240 kB-1 B (-0.0%)
    firestore (Read data once)228 kB228 kB-1 B (-0.0%)
    firestore (Read Write w Persistence)325 kB325 kB-1 B (-0.0%)
    firestore (Realtime updates)230 kB230 kB-1 B (-0.0%)
    firestore (Transaction)207 kB207 kB-1 B (-0.0%)
    firestore (Write data)207 kB207 kB-1 B (-0.0%)
    firestore-lite (Query Cursors)91.5 kB91.5 kB+1 B (+0.0%)
    firestore-lite (Query)87.6 kB87.6 kB+1 B (+0.0%)
    firestore-lite (Read data once)63.1 kB63.1 kB+1 B (+0.0%)
    firestore-lite (Transaction)88.4 kB88.4 kB+1 B (+0.0%)
    firestore-lite (Write data)72.7 kB72.7 kB+1 B (+0.0%)
    functions (call)32.0 kB32.0 kB+1 B (+0.0%)
    messaging (send + receive)47.0 kB53.6 kB+6.59 kB (+14.0%)
    performance (trace)51.8 kB55.1 kB+3.30 kB (+6.4%)
    remote-config (getAndFetch)46.3 kB49.6 kB+3.29 kB (+7.1%)
    storage (getBytes)42.1 kB42.1 kB+1 B (+0.0%)
    storage (getDownloadURL)44.2 kB44.2 kB+1 B (+0.0%)
    storage (getMetadata)43.7 kB43.7 kB+1 B (+0.0%)
    storage (list + listAll)43.1 kB43.1 kB+1 B (+0.0%)
    storage (updateMetadata)43.9 kB43.9 kB+1 B (+0.0%)
    storage (uploadBytes)48.8 kB48.8 kB+1 B (+0.0%)
    storage (uploadBytesResumable)58.7 kB58.7 kB+1 B (+0.0%)
    storage (uploadString)49.0 kB49.0 kB+1 B (+0.0%)

  • firebase

    TypeBase (beaa4df)Merge (3809f73)Diff
    firebase-analytics-compat.js26.5 kB26.5 kB+4 B (+0.0%)
    firebase-app-compat.js31.8 kB31.8 kB-29 B (-0.1%)
    firebase-compat.js788 kB797 kB+9.03 kB (+1.1%)
    firebase-messaging-compat.js38.4 kB44.5 kB+6.08 kB (+15.8%)
    firebase-messaging-sw.js30.2 kB33.6 kB+3.43 kB (+11.4%)
    firebase-messaging.js28.7 kB32.2 kB+3.43 kB (+11.9%)
    firebase-performance-compat.js30.8 kB30.8 kB+4 B (+0.0%)
    firebase-performance-standalone-compat.es2017.js93.7 kB96.7 kB+2.99 kB (+3.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TCKkdAVyST.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 24, 2024 •
edited
Loading

Size Analysis Report 1

This report is too large (308,729 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/hIYjf0GGCF.html

@dlarocque dlarocque closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi will be requested when the pull request is marked ready for review avolkovi is a code owner

@yoyomyo yoyomyo Awaiting requested review from yoyomyo yoyomyo will be requested when the pull request is marked ready for review yoyomyo is a code owner

@zwu52 zwu52 Awaiting requested review from zwu52 zwu52 will be requested when the pull request is marked ready for review zwu52 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlarocque @google-oss-bot